Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog merging across MC versions #19

Merged
merged 26 commits into from
Aug 28, 2024

Conversation

Thodor12
Copy link
Contributor

No description provided.

Copy link
Member

@Nightenom Nightenom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergeable, var names look correct

steps:
- id: checkout
name: "📦 Checkout"
uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-depth: 1000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At Orion: i think we can lower this something more sensible like 100? (not sure where 1k comes from, but iirc neo has changelog generation since fixed version so that's why)

uses: PaulHatch/[email protected]
with:
tag_prefix: "v"
tag_prefix: "v${{ steps.generateMinecraftVersion.outputs.minecraft_version }}-"
search_commit_body: true
debug: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need debug for this? isnt that linked to running action in debug mode?

@marchermans marchermans merged commit e65a713 into ldtteam:ng7 Aug 28, 2024
1 check passed
@Thodor12 Thodor12 deleted the fix/changelog-merging branch August 28, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants